Skip to content

Fix rational division by zero #40551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2021
Merged

Fix rational division by zero #40551

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f210ac
Fix rational division by zero
blegat Apr 21, 2021
8a534c9
Replace `BigFloat` by `BigInt`
blegat Apr 21, 2021
f026f15
Update tests
blegat Apr 21, 2021
953766c
Simplify tests
blegat Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/gmp.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@ function Base.://(x::Rational{BigInt}, y::Rational{BigInt})
if iszero(x.num)
throw(DivideError())
end
return (isneg(x.num) ? -one(BigFloat) : one(BigFloat)) // y.num
return isneg(x.num) ? typemin(BigFloat) : typemax(BigFloat)
end
zq = _MPQ()
ccall((:__gmpq_div, :libgmp), Cvoid,
Expand Down
12 changes: 12 additions & 0 deletions test/gmp.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,18 @@ ee = typemax(Int64)
@test big(typeof(complex(x, x))) == typeof(big(complex(x, x)))
end
end
@testset "division" begin
oz = big(2 // 0)
zo = big(0 // 2)

@test_throws DivideError() oz / oz
@test oz == oz / one(oz)
@test -oz == oz / (-one(oz))
@test zero(oz) == one(oz) / oz
@test_throws DivideError() zo / zo
@test typemax(BigFloat) == one(zo) / zo
@test typemin(BigFloat) == -one(zo) / zo
end
end
@testset "div, fld, mod, rem" begin
for i = -10:10, j = [-10:-1; 1:10]
Expand Down