Fix duplicate error when using bad generator in Dict #40445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omus
added
error handling
Member
|
Oof, this error path is so ugly. I wonder if we could remove all the try blocks, and instead check for this case by examining the stack during error printing. That might be more accurate as well, better distinguishing errors actually caused by invalid elements. |
Member
|
Bump. |
vtjnash
added a commit
that referenced
this pull request
Feb 1, 2024
Fixes: #33147 Replaces/Closes: #40445 Co-authored-by: Jameson Nash <[email protected]>
vtjnash
added a commit
that referenced
this pull request
Feb 1, 2024
Fixes: #33147 Replaces/Closes: #40445 Co-authored-by: Jameson Nash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #33147