fix #32843, codegen attempting typeof(NULL) for some union tags
#40365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fixes part of #40065
JeffBezanson
added
compiler:codegen
vtjnash
reviewed
Apr 6, 2021
| ti->addIncoming(Constant::getNullValue(typof->getType()), entry); | ||
| ti->addIncoming(typof, nonnull); | ||
| return ti; | ||
| } |
Member
There was a problem hiding this comment.
FWIW, we have a concise form of this function's pattern now. No need to change this, just thought I'd let you know about the alternative:
Value *isnull = ctx.builder.CreateIsNull(v);
return emit_guarded_test(ctx, isnull, V_rnull, [&] {
return emit_typeof(ctx, v);
});
vtjnash
approved these changes
Apr 6, 2021
Member
|
I merged this into #40209 with the assumption that this will be merged to master so I can run a PkgEval with this included. |
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
… tags (JuliaLang#40365) also fixes part of JuliaLang#40065
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
… tags (JuliaLang#40365) also fixes part of JuliaLang#40065
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
… tags (JuliaLang#40365) also fixes part of JuliaLang#40065
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes part of #40065