[release-1.6] Prevent PCRE from needing a rebuild/reconf. #40062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reorders a couple touches in deps/pcre.mkl. Those touches are intended to prevent patch application from triggering rebuild/reconf. The present ordering doesn't quite succeed in that objective; patch application triggers rebuild. On systems with compatible autotools, the rebuild succeeds and the build is nonetheless happy. On systems with incompatible versions of autotools, however, the build fails for need of a reconf. The reordering in this commit prevents the rebuild. Co-Authored-By: Rob Vermaas <[email protected]>
Member
|
I think we usually target |
staticfloat
approved these changes
Mar 16, 2021
Member
Author
Yes, I targeted |
Member
|
Included in #40150 |
Member
Author
|
Thanks Kristoffer! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies only to
release-1.6; the relevant patches and touches are gone onmaster:).@KristofferC, let me know if I should target some other branch :).
cc @rbvermaa