-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
more efficient array indexing with AbstractUnitRange #39896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2f8cbdc
Method signature relaxed for getindex(A::Array, I::UnitRange{Int})
sanjibansg 152935d
Tests added for getindex
sanjibansg 710c2b9
Tests updated for getindex
sanjibansg 9fcac4b
Tests updated for OneTo of smaller endpoints
sanjibansg 4b67ad7
Tests now uses collect in place of ones
sanjibansg 310a728
Endpoints to OneTo corrected
sanjibansg 7eed6ec
Tests for UInt and BigInt ranges added
sanjibansg a72b6e8
Tests modified
sanjibansg 268b4a2
Type testing and linear indexing added
sanjibansg 9481591
Boolean support for indexing with tests added
sanjibansg b47570c
Boolean support for multidimensional arrays added
sanjibansg f96a54a
Indentation corrected
sanjibansg 9d6d575
Comments added and indentation corrected
sanjibansg f461291
Indentation corrected
sanjibansg fc5823a
whitespace removed
sanjibansg 61339fb
Final newline added
sanjibansg 5e8c7d4
Trailing whitespaces removed
sanjibansg ec9da39
Merge branch 'master' into arrayindex
sanjibansg ebe19e4
Update test/abstractarray.jl
sanjibansg 233566b
Update test/abstractarray.jl
sanjibansg 87c0a7d
Merge remote-tracking branch 'origin/master' into arrayindex
simeonschaub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.