Skip to content

ensure to show the whole type, even if the proper subset matched an alias #39728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vtjnash merged 2 commits into from
Feb 22, 2021
Merged

ensure to show the whole type, even if the proper subset matched an alias #39728

vtjnash merged 2 commits into from
Feb 22, 2021

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Feb 18, 2021

Fixes #39723

@vtjnash
ensure to show the whole type, even if the proper subset matched an a…
b729667 
…lias

This code should only have been active for make_typealiases, but #38099
already fixed that better, so we can just remove this now.

Fixes #39723
@vtjnash
when showing union aliases, keep TypeVars last
edd3c87
@vtjnash vtjnash added the backport 1.6 Change should be backported to release-1.6 label Feb 18, 2021
@JeffBezanson JeffBezanson added the display and printing Aesthetics and correctness of printed representations of objects. label Feb 18, 2021
@vtjnash vtjnash merged commit 10bea87 into master Feb 22, 2021
@vtjnash vtjnash deleted the jn/39723 branch February 22, 2021 04:57
@KristofferC KristofferC mentioned this pull request Feb 22, 2021
Merged
52 tasks
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

display and printing Aesthetics and correctness of printed representations of objects.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error in printing method signatures with Unions and type parameters

4 participants

@vtjnash @JeffBezanson @KristofferC