Skip to content

Add missing imports to SuiteSparse tests #39539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keno merged 1 commit into from
Feb 6, 2021
Merged

Add missing imports to SuiteSparse tests #39539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion stdlib/SuiteSparse/test/cholmod.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
# This file is a part of Julia. License is MIT: https://julialang.org/license

using SuiteSparse.CHOLMOD
using SuiteSparse
using DelimitedFiles
using Test
using Random
using Serialization
using LinearAlgebra: issuccess, PosDefException, ZeroPivotException
using LinearAlgebra:
I, cholesky, cholesky!, det, diag, eigmax, ishermitian, isposdef, issuccess,
issymmetric, ldlt, ldlt!, logdet, norm, opnorm, Diagonal, Hermitian, Symmetric,
PosDefException, ZeroPivotException
using SparseArrays
using SparseArrays: getcolptr

Expand Down
4 changes: 3 additions & 1 deletion stdlib/SuiteSparse/test/spqr.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

using SuiteSparse.SPQR
using SuiteSparse.CHOLMOD
using LinearAlgebra: rmul!, lmul!, Adjoint, Transpose
using SuiteSparse
using LinearAlgebra: I, istriu, norm, qr, rank, rmul!, lmul!, Adjoint, Transpose
using SparseArrays: sparse, sprandn, spzeros, SparseMatrixCSC

@testset "Sparse QR" begin
m, n = 100, 10
Expand Down
24 changes: 14 additions & 10 deletions stdlib/SuiteSparse/test/umfpack.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# This file is a part of Julia. License is MIT: https://julialang.org/license

using SuiteSparse.UMFPACK
using SuiteSparse
using SuiteSparse: increment!
using Serialization
using LinearAlgebra: Adjoint, Transpose, SingularException
using LinearAlgebra:
I, det, issuccess, ldiv!, lu, lu!, Adjoint, Transpose, SingularException, Diagonal
using SparseArrays: nnz, sparse, sprand, sprandn, SparseMatrixCSC

@testset "UMFPACK wrappers" begin
se33 = sparse(1.0I, 3, 3)
Expand Down Expand Up @@ -33,11 +37,11 @@ using LinearAlgebra: Adjoint, Transpose, SingularException

@test A*x ≈ b
z = complex.(b)
x = LinearAlgebra.ldiv!(lua, z)
x = ldiv!(lua, z)
@test x ≈ float([1:5;])
@test z === x
y = similar(z)
LinearAlgebra.ldiv!(y, lua, complex.(b))
ldiv!(y, lua, complex.(b))
@test y ≈ x

@test A*x ≈ b
Expand All @@ -48,22 +52,22 @@ using LinearAlgebra: Adjoint, Transpose, SingularException

@test A'*x ≈ b
z = complex.(b)
x = LinearAlgebra.ldiv!(adjoint(lua), z)
x = ldiv!(adjoint(lua), z)
@test x ≈ float([1:5;])
@test x === z
y = similar(x)
LinearAlgebra.ldiv!(y, adjoint(lua), complex.(b))
ldiv!(y, adjoint(lua), complex.(b))
@test y ≈ x

@test A'*x ≈ b
x = transpose(lua) \ b
@test x ≈ float([1:5;])

@test transpose(A) * x ≈ b
x = LinearAlgebra.ldiv!(transpose(lua), complex.(b))
x = ldiv!(transpose(lua), complex.(b))
@test x ≈ float([1:5;])
y = similar(x)
LinearAlgebra.ldiv!(y, transpose(lua), complex.(b))
ldiv!(y, transpose(lua), complex.(b))
@test y ≈ x

@test transpose(A) * x ≈ b
Expand Down Expand Up @@ -165,9 +169,9 @@ using LinearAlgebra: Adjoint, Transpose, SingularException
X = zeros(ComplexF64, N, N)
B = complex.(rand(N, N), rand(N, N))
luA, lufA = lu(A), lu(Array(A))
@test LinearAlgebra.ldiv!(copy(X), luA, B) ≈ LinearAlgebra.ldiv!(copy(X), lufA, B)
@test LinearAlgebra.ldiv!(copy(X), adjoint(luA), B) ≈ LinearAlgebra.ldiv!(copy(X), adjoint(lufA), B)
@test LinearAlgebra.ldiv!(copy(X), transpose(luA), B) ≈ LinearAlgebra.ldiv!(copy(X), transpose(lufA), B)
@test ldiv!(copy(X), luA, B) ≈ ldiv!(copy(X), lufA, B)
@test ldiv!(copy(X), adjoint(luA), B) ≈ ldiv!(copy(X), adjoint(lufA), B)
@test ldiv!(copy(X), transpose(luA), B) ≈ ldiv!(copy(X), transpose(lufA), B)
end

@testset "singular matrix" begin
Expand Down