improve precompile generation script #37918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to improve on the gripe here: #37904 (comment).
Instead of executing everything in the REPL process, we only execute those parts that are used to precompile specific REPL things (like tab completion, showing error messages etc). The rest is executed in a normal process which will throw if an error is produced (which turns #37904 into a hard error instead of a silent one):
Note that the offending line in #37904 is commented out because even with the change suggested in there, it fails.