Skip to content

Conversation

@jaideep-seth
Copy link
Contributor

@jaideep-seth jaideep-seth commented Nov 12, 2019

This is an attempt for only '@' (One of seven) described in this issue.

Reference: #33666

@mbauman
Copy link
Member

mbauman commented Nov 12, 2019

Welcome @jaideep-seth! This looks like a good take on tackling part of #33666. In general, I encourage you to use more descriptive commit messages — which can then auto-populate your pull request with title and description. Just saying something like: "add docstring for @ at the REPL" would be great — you can still edit the title and body of this PR, which would be very helpful to others.

@mbauman mbauman added the docs This change adds or pertains to documentation label Nov 12, 2019
@jaideep-seth
Copy link
Contributor Author

jaideep-seth commented Nov 12, 2019

Hi @mbauman , this is my first PR in Julia. Please help me get this PR merged.

Thank you so much!

@jaideep-seth jaideep-seth changed the title try1 add docstring for @ at the REPL Nov 12, 2019
@jaideep-seth
Copy link
Contributor Author

Hey @mbauman i raised an issue ( #33844 ) as the buildbot asked me to in the build log.

Could you please guide me on how i can clear the remaining build tests?
Thank you!

@ViralBShah
Copy link
Member

Hi @jaideep-seth - the buildbots are not related to your PR. Please improve the commit message and make it descriptive as suggested.

Co-authored-by: jaideep-seth <[email protected]>
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Apr 20, 2021
@fredrikekre fredrikekre merged commit 6985788 into JuliaLang:master Apr 21, 2021
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Apr 28, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
Co-authored-by: jaideep-seth <[email protected]>

Co-authored-by: Jameson Nash <[email protected]>
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
Co-authored-by: jaideep-seth <[email protected]>

Co-authored-by: Jameson Nash <[email protected]>
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Co-authored-by: jaideep-seth <[email protected]>

Co-authored-by: Jameson Nash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs This change adds or pertains to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants