Fix findfirst with decreasing step range #33809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
approved these changes
Nov 11, 2019
rfourquet
approved these changes
Nov 11, 2019
raminammour
reviewed
Nov 11, 2019
Contributor
raminammour
left a comment
raminammour
left a comment
There was a problem hiding this comment.
Maybe add:
isempty(r) && return nothing
Fixes things like:
julia> findfirst(==(2),1:-1:2)
0
dkarrasch
reviewed
Nov 11, 2019
dkarrasch
approved these changes
Nov 12, 2019
Member
|
Man, what's going on with CI? 6 ❌s, all different and seemingly unrelated!? Let's try that again. |
raminammour
approved these changes
Nov 12, 2019
JeffBezanson
pushed a commit
that referenced
this pull request
Nov 13, 2019
56 tasks
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33808
findfirstassumed increasing step size forStepRange.