Skip to content

Conversation

@staticfloat
Copy link
Member

This reverts commit 7f2922e.

I think this commit broke Documenter, which is breaking all our buildbot builds. Let's see if this actually fixes it.

@staticfloat
Copy link
Member Author

Yes, this does fix it. (doctest_linux64 passes)

@staticfloat staticfloat requested review from kshyatt and vtjnash August 6, 2019 16:13
@staticfloat
Copy link
Member Author

staticfloat commented Aug 6, 2019

Whoops, didn't mean to ping you Jameson, the GitHub UI jumped under my cursor when attempting to click Katie's name.

I'm pinging you Katie because these were your changes, and I want to make sure that you know you'll need to re-submit them. I've opened an issue against Documenter.jl to figure out why this is causing problems.

@staticfloat staticfloat merged commit 8aeb398 into master Aug 6, 2019
@staticfloat staticfloat deleted the sf/revert_documenter_deaths branch August 6, 2019 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants