Fix link to Sys.cpu_info #32807
Closed
Fix link to Sys.cpu_info #32807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes building the Documenter docs.
dkarrasch
reviewed
Aug 6, 2019
base/sysinfo.jl
Outdated
|
|
||
| """ | ||
| Sys.cpu_summary(io::IO=stdout, cpu::AbstractVector{CPUinfo} = cpu_info()) | ||
| Sys.cpu_summary(io::IO=stdout, cpu::AbstractVector{CPUinfo} = Sys.cpu_info()) |
Member
There was a problem hiding this comment.
Perhaps we should remove the whitespaces in the second keyword argument? It took me quite a few seconds to parse that line and to see whether there is an assignment going on here...
Member
|
Good catch @nalimilan; I went the nuclear route and reverted the whole commit. You'll need to rebase on top of that. |
Member
Author
|
AFAICT there's nothing to rebase since the changes in this PR applied to a docstring which has been removed by the revert. They will just have to be applied to the un-reverting PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes building the Documenter docs. Introduced by #31204.