-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
make shared array constructor consistent to array constructor #29930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Not sure who the best person to review |
|
@mbauman What about return So in my case, I tried to implement something with generic array type, which allows me to run either on multiprocess with I currently have to work around this like: |
|
@Roger-luo Are you still interested in this PR? |
|
(I've cancelled CI for now. I'll re-trigger CI if we decide we're still interested in this PR.) |
I'm not sure if thisinitis still needed? can we just provide it withfillinterface?Why do we need ainitfunction in the constructor?undeffor uninitializedSharedArray, but preserve theinitkeyword (you need it for files)similarshould returnSharedArray