Skip to content

RFC: Don't bail current_project() at Git repos#29108

Merged
StefanKarpinski merged 1 commit intoJuliaLang:masterfrom
mortenpi:mp/fix-current_project
Sep 11, 2018
Merged

RFC: Don't bail current_project() at Git repos#29108
StefanKarpinski merged 1 commit intoJuliaLang:masterfrom
mortenpi:mp/fix-current_project

Conversation

@mortenpi
Copy link
Copy Markdown
Contributor

@mortenpi mortenpi commented Sep 9, 2018

Currently, assuming you have the following directory structure

myproject/Project.toml
myproject/non-julia-repo/.git

running julia --project somewhere in myproject/non-julia-repo will not activate myproject/.

I don't quite see why Git repos are treated specially here, so in the PR I propose removing the .git directory check in current_project and let it continue searching up the directory tree for Project.tomls.

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Sep 10, 2018

Let me think about this for a bit but ping me in a couple days if I don't reply...

StefanKarpinski
StefanKarpinski approved these changes Sep 11, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@StefanKarpinski StefanKarpinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, ok, this is fine.

@StefanKarpinski StefanKarpinski merged commit 70c7298 into JuliaLang:master Sep 11, 2018
@fredrikekre
Copy link
Copy Markdown
Member

fredrikekre commented Sep 11, 2018

Eligible for backport?

@KristofferC
Copy link
Copy Markdown
Member

KristofferC commented Sep 11, 2018

I guess technically not...

@StefanKarpinski
Copy link
Copy Markdown
Member

StefanKarpinski commented Sep 12, 2018

Yeah, let's leave this one for 1.1 instead. It does need NEWS as well.

@StefanKarpinski StefanKarpinski added this to the 1.1 milestone Sep 12, 2018
@StefanKarpinski StefanKarpinski added the needs news A NEWS entry is required for this change label Sep 12, 2018
@mortenpi mortenpi deleted the mp/fix-current_project branch September 12, 2018 04:43
mortenpi added a commit to mortenpi/julia that referenced this pull request Dec 1, 2018
@mortenpi
News and compat annotation for JuliaLang#29108 (current_project() / -…
39051de 
…-project=@.)
fredrikekre pushed a commit that referenced this pull request Dec 1, 2018
@mortenpi @fredrikekre
News and compat annotation for #29108 (current_project() / --project=@.)
7ca14b4
mortenpi added a commit to mortenpi/julia that referenced this pull request Dec 1, 2018
@mortenpi
squash! News and compat annotation for JuliaLang#29108 (current_proje…
e34ee1b 
…ct() / --project=@.)
fredrikekre pushed a commit that referenced this pull request Dec 1, 2018
@mortenpi @fredrikekre
News and compat annotation for #29108 (current_project() / --project=@.)
3dfd4bc
fredrikekre pushed a commit that referenced this pull request Dec 3, 2018
@mortenpi @fredrikekre
News and compat annotation for #29108 (current_project() / --project=@.)
dd2321b
fredrikekre pushed a commit that referenced this pull request Dec 4, 2018
@mortenpi @fredrikekre
News and compat annotation for #29108 (current_project() / --project=@.)
4566c64
fredrikekre pushed a commit that referenced this pull request Dec 4, 2018
@mortenpi @fredrikekre
News and compat annotation for #29108 (current_project() / --project=@.)
41c2bd6
fredrikekre added a commit that referenced this pull request Dec 5, 2018
@mortenpi @fredrikekre
Addition of NEWS and compat admonitions for important
cceb675 
changes between Julia 1.0 and 1.1, including:

- Custom .css-style for compat admonitions.

- Information about compat annotations to CONTRIBUTING.md.

- NEWS.md entry for PRs #30090, #30035, #30022, #29978,
  #29969, #29858, #29845, #29754, #29638, #29636, #29615,
  #29600, #29506, #29469, #29316, #29259, #29178, #29153,
  #29033, #28902, #28761, #28745, #28708, #28696, #29997,
  #28790, #29092, #29108, #29782

- Compat annotation for PRs #30090, #30013, #29978,
  #29890, #29858, #29827, #29754, #29679, #29636, #29623,
  #29600, #29440, #29316, #29259, #29178, #29157, #29153,
  #29033, #28902, #28878, #28761, #28708, #28156, #29733,
  #29670, #29997, #28790, #29092, #29108, #29782, #25278

- Documentation for broadcasting CartesianIndices (#30230).
- Documentation for Base.julia_cmd().
- Documentation for colon constructor of CartesianIndices (#29440).
- Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix).

- Run NEWS-update.jl.

Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre added a commit that referenced this pull request Dec 5, 2018
@mortenpi @fredrikekre
Addition of NEWS and compat admonitions for important
ebbabf5 
changes between Julia 1.0 and 1.1, including:

- Custom .css-style for compat admonitions.

- Information about compat annotations to CONTRIBUTING.md.

- NEWS.md entry for PRs #30090, #30035, #30022, #29978,
  #29969, #29858, #29845, #29754, #29638, #29636, #29615,
  #29600, #29506, #29469, #29316, #29259, #29178, #29153,
  #29033, #28902, #28761, #28745, #28708, #28696, #29997,
  #28790, #29092, #29108, #29782

- Compat annotation for PRs #30090, #30013, #29978,
  #29890, #29858, #29827, #29754, #29679, #29636, #29623,
  #29600, #29440, #29316, #29259, #29178, #29157, #29153,
  #29033, #28902, #28878, #28761, #28708, #28156, #29733,
  #29670, #29997, #28790, #29092, #29108, #29782, #25278

- Documentation for broadcasting CartesianIndices (#30230).
- Documentation for Base.julia_cmd().
- Documentation for colon constructor of CartesianIndices (#29440).
- Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix).

- Run NEWS-update.jl.

Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
fredrikekre added a commit that referenced this pull request Dec 5, 2018
@fredrikekre @mortenpi
Compat admonitions and NEWS for Julia 1.1 (#30230)
6175bd9 
Addition of NEWS and compat admonitions for important changes between Julia 1.0 and 1.1, including:

- Custom .css-style for compat admonitions.

- Information about compat annotations to CONTRIBUTING.md.

- NEWS.md entry for PRs #30090, #30035, #30022, #29978,
  #29969, #29858, #29845, #29754, #29638, #29636, #29615,
  #29600, #29506, #29469, #29316, #29259, #29178, #29153,
  #29033, #28902, #28761, #28745, #28708, #28696, #29997,
  #28790, #29092, #29108, #29782

- Compat annotation for PRs #30090, #30013, #29978,
  #29890, #29858, #29827, #29754, #29679, #29636, #29623,
  #29600, #29440, #29316, #29259, #29178, #29157, #29153,
  #29033, #28902, #28878, #28761, #28708, #28156, #29733,
  #29670, #29997, #28790, #29092, #29108, #29782, #25278

- Documentation for broadcasting CartesianIndices (#30230).
- Documentation for Base.julia_cmd().
- Documentation for colon constructor of CartesianIndices (#29440).
- Documentation for ^(::Matrix, ::Number) and ^(::Number, ::Matrix).

- Run NEWS-update.jl.


Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees

No one assigned

Labels

needs news A NEWS entry is required for this change

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

4 participants

@mortenpi @StefanKarpinski @fredrikekre @KristofferC