Revert "Revert "enable the SLP Vectorizer optimization pass by default"" #27659
+5
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do you have results on the effect this has on compile time? |
Member
Author
|
@KristofferC had some in his original PR #26594, but I haven't measured it myself. |
Member
|
As far as I can tell, "new enough CPU" means "has AVX512", which, unfortunately, none of mine do. :( |
Member
Author
|
@nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Member
|
@vchuravy For the benefit of passers by such as myself, can you explain why this was closed? |
Member
Author
|
Mostly spring cleaning, we can keep this open, but I won't have time to work on it and keeping it open gives the illusion that I do ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #27049
After #27182 we should be able to run the SLP by default again. Can someone one a new enough CPU confirm?