Skip to content

Make test tolerance dependent on condition number in Bunch-Kaufman test#25103

Merged
vchuravy merged 1 commit into
masterfrom
anj/25096
Dec 15, 2017
Merged

Make test tolerance dependent on condition number in Bunch-Kaufman test#25103
vchuravy merged 1 commit into
masterfrom
anj/25096

Conversation

@andreasnoack
Copy link
Copy Markdown
Member

Fixes #25096

@andreasnoack andreasnoack added linear algebra Linear algebra test This change adds or pertains to unit tests labels Dec 15, 2017
@rfourquet
Copy link
Copy Markdown
Member

If this can help, this error can be seen on CI, with RNG seed 0x48c527989c99cb3db9f41553cee8fc9e.

Comment thread test/linalg/bunchkaufman.jl Outdated
bimg = randn(n,2)/2

@testset "$eltya argument A" for eltya in (Float32, Float64, ComplexF32, ComplexF64, Int)
@testset "$eltya argument A" for eltya in (Float32, Float64, Complex64, Complex128, Int)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slowly reverting the Complex renaming PR? 😉

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Copy Markdown
Member

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo AV i686 signoff! Thanks @andreasnoack! :)

@vchuravy vchuravy merged commit e3b01be into master Dec 15, 2017
@Sacha0 Sacha0 deleted the anj/25096 branch December 15, 2017 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear algebra Linear algebra test This change adds or pertains to unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants