at-[s]printf to Printf stdlib #25056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
deprecation
Member
|
Bravo and thank you! |
fredrikekre
force-pushed
the
fe/stdlib-printf
branch
from
b958227 to
83efcc1
Compare
fredrikekre
force-pushed
the
fe/stdlib-printf
branch
2 times, most recently
from
6b0c22b to
d9578dd
Compare
ararslan
reviewed
Dec 15, 2017
base/sysimg.jl
Outdated
| # (s)printf macros | ||
| include("printf.jl") | ||
| using .Printf | ||
| import .Printf |
Member
There was a problem hiding this comment.
Is this import necessary so that Printf.@printf overrides Base.Printf.@printf?
Member
|
Looks like there's a vestigial use of |
Member
|
Seems to be in shape apart from needing a rebase, a fix for the logging PR interaction, and a CI rerun? |
fredrikekre
force-pushed
the
fe/stdlib-printf
branch
from
d9578dd to
6cd1d6c
Compare
Member
Author
|
Rebased, and tests passes locally |
fredrikekre
force-pushed
the
fe/stdlib-printf
branch
from
6cd1d6c to
0e09ecd
Compare
fredrikekre
force-pushed
the
fe/stdlib-printf
branch
from
0e09ecd to
8ab6f01
Compare
Sacha0
approved these changes
Dec 16, 2017
Member
There was a problem hiding this comment.
superficially lgtm from a skim! Thanks @fredrikekre! :)
Member
|
The macOS run is timing out on some kind of dependency installation. Yolo. |
Contributor
|
I like |
Member
|
Yes |
martinholters
added a commit
to martinholters/ProgressMeter.jl
that referenced
this pull request
Dec 29, 2017
Needed due to JuliaLang/julia#25056.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
@printfand@sprintfto the stdlib modulePrintf(perhaps we can have a better name for that?FormattedPrinting?PrettyPrinting?)Implementation is still mostly in
base/printf.jlto let Base use these.close #23929