deprecate contains(eq, itr, item)
#23716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
deprecation
ararslan
reviewed
Sep 14, 2017
| return p | ||
| end | ||
|
|
||
| @deprecate contains(eq::Function, itr, x) any(y->eq(y,x), itr) |
Member
There was a problem hiding this comment.
Huh, so that's what this method was for.
ararslan
reviewed
Sep 14, 2017
NEWS.md
Outdated
| this is not true. If you are certain you need the old behavior, it is temporarily available | ||
| as `Base._isleaftype` ([#17086]). | ||
|
|
||
| * `contains(eq, itr, item)` is deprecated in favor of `any` with a predicate. |
Member
There was a problem hiding this comment.
It'd be great if you could add the PR reference here.
ararslan
approved these changes
Sep 14, 2017
Member
ararslan
left a comment
ararslan
left a comment
There was a problem hiding this comment.
LGTM aside from the minor NEWS item note.
JeffBezanson
force-pushed
the
jb/contains
branch
from
2a62586 to
ac4ec7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.