Skip to content

some I/O deprecations #22456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JeffBezanson merged 1 commit into from
Jul 10, 2017
Merged

some I/O deprecations #22456

JeffBezanson merged 1 commit into from
Jul 10, 2017

Conversation

@JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Jun 21, 2017 •
edited by nalimilan
Loading

change read(::IO, ::Ref) to read!, fix fix #21592

deprecate read(io, type, dims), fix #21450

@JeffBezanson JeffBezanson added deprecation This change introduces or involves a deprecation io Involving the I/O subsystem: libuv, read, write, etc. labels Jun 21, 2017
@tkelman tkelman added the needs news A NEWS entry is required for this change label Jun 21, 2017
@JeffBezanson JeffBezanson removed the needs news A NEWS entry is required for this change label Jun 21, 2017
vtjnash
vtjnash reviewed Jun 21, 2017
View reviewed changes
base/serialize.jl
end
else
A = read(s.io, elty, dims)
A = read!(s.io, Array{elty}(dims))
Copy link
Member

@vtjnash vtjnash Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vector{elty} will probably be significantly faster

Copy link
Member Author

@JeffBezanson JeffBezanson Jun 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of dimensions isn't known.

@JeffBezanson
Copy link
Member Author

JeffBezanson commented Jul 1, 2017

@yuyichao @Keno Interesting failure on win32 here.

@JeffBezanson
change read(::IO, ::Ref) to read!`, fix fix #21592
d61d5ac 
deprecate `read(io, type, dims)`, fix #21450
@JeffBezanson JeffBezanson merged commit 1e95e1d into master Jul 10, 2017
@JeffBezanson JeffBezanson deleted the jb/iodeps branch July 10, 2017 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vtjnash vtjnash vtjnash left review comments

Assignees

No one assigned

Labels

deprecation This change introduces or involves a deprecation io Involving the I/O subsystem: libuv, read, write, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

read(::IO, ::Ref) should be a method of read! deprecate read(io, type, dims)

4 participants

@JeffBezanson @vtjnash @tkelman