Add the corresponding iterator trait to size(::Number) = ()#16444
Merged
Conversation
Contributor
|
There's a bit of a desire to make numbers not iterable in which case this is not meaningful, ref #7903 |
Author
|
I know, I did not want to touch that subject, it is just the right thing for the current situation. |
Author
|
PS: I think now that this definition takes a bit of the pressure away to proceed with #7903. |
Member
|
Regardless of whether numbers are iterable, they have to work with broadcast so that you can do things like In which case it makes sense for them to have the corresponding trait? (And, in fact, the |
Author
|
@stevengj Yes, exactly. I just wrote a similar statement over there in 7903. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes numbers well behaved with the
productiterator and withcollect: For example nowand after merging #16437 thanks to #15431
for an array
A.