Systematically address SubArrays in test/linalg/svd.jl #15314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
💯 (looks like you may have introduced some tabs) |
kshyatt
added
test
Member
|
Nice! Thanks for doing this - as @StefanKarpinski said, as soon as the tabs are fixed, this LGTM. @andreasnoack? |
Contributor
Author
|
When you say tabs, do you mean the extra indentation because of an additional for loop? |
tkelman
added a commit
that referenced
this pull request
Mar 3, 2016
Systematically address SubArrays in test/linalg/svd.jl
This was referenced Mar 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re JuliaLang/LinearAlgebra.jl#299
Following the approach in #14731,
svd.jlnow coversSubArrays.I also added a tiny test of
x^yforx::Complet{T}whereT<:AbstractFloatandy::Rationalwhich I missed in #15216. It's a bit small of a change for a separate PR, but it's in a different commit, so I hope that is fine.