WIP: Generalize indexing fallbacks #12490
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take on #12486. Easiest to just show what this enables:
But there are two problems:
The first commit is definitely correct. We should do that no matter what. The second commit means that we get N deprecation warnings for indexing with an N-element array of floats. And I don't know how to structure dispatch so we can pass along unknown non-Array types to multidimensional indexing without ending up with stack overflows.
I need to stop working on this for now, but I wanted to push this so y'all can see what I'm thinking.