Skip to content

Commit 4b58679

Browse files
authored
Fewer warnings in 'make clean' in clean directory (#44450)
* Fewer warnings in 'make clean' in clean directory * Don't ignore exit code for 'rm -rf'
1 parent bbdd5d7 commit 4b58679

30 files changed

+63
-63
lines changed

Make.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1394,15 +1394,15 @@ clean-$$(abspath $(2)/$(3)):
13941394
ifeq ($(BUILD_OS), WINNT)
13951395
-cmd //C rmdir $$(call mingw_to_dos,$(2)/$(3),cd $(2) &&)
13961396
else
1397-
-rm -r $$(abspath $(2)/$(3))
1397+
rm -rf $$(abspath $(2)/$(3))
13981398
endif
13991399
$$(abspath $(2)/$(3)): | $$(abspath $(2))
14001400
ifeq ($$(BUILD_OS), WINNT)
14011401
@cmd //C mklink //J $$(call mingw_to_dos,$(2)/$(3),cd $(2) &&) $$(call mingw_to_dos,$(1),)
14021402
else ifneq (,$$(findstring CYGWIN,$$(BUILD_OS)))
14031403
@cmd /C mklink /J $$(call cygpath_w,$(2)/$(3)) $$(call cygpath_w,$(1))
14041404
else ifdef JULIA_VAGRANT_BUILD
1405-
@rm -r $$@
1405+
@rm -rf $$@
14061406
@cp -R $$(abspath $(1)) [email protected]
14071407
14081408
else

base/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ $$(build_private_libdir)/$$(libname_$2):
169169
REALPATH=$$(libpath_$2); \
170170
$$(call resolve_path,REALPATH) && \
171171
[ -e "$$$$REALPATH" ] && \
172-
([ ! -e "$$@" ] || rm "$$@") && \
172+
rm -f "$$@" && \
173173
echo ln -sf "$$$$REALPATH" "$$@" && \
174174
ln -sf "$$$$REALPATH" "$$@"; \
175175
else \
@@ -193,7 +193,7 @@ endif
193193

194194
$(build_bindir)/7z$(EXE):
195195
[ -e "$(7Z_PATH)" ] && \
196-
([ ! -e "$@" ] || rm "$@") && \
196+
rm -f "$@" && \
197197
ln -svf "$(7Z_PATH)" "$@"
198198

199199
# the following excludes: libuv.a, libutf8proc.a
@@ -258,7 +258,7 @@ $(build_private_libdir)/libLLVM.$(SHLIB_EXT):
258258
REALPATH=$(LLVM_CONFIG_HOST_LIBS) && \
259259
$(call resolve_path,REALPATH) && \
260260
[ -e "$$REALPATH" ] && \
261-
([ ! -e "$@" ] || rm "$@") && \
261+
rm -f "$@" && \
262262
echo ln -sf "$$REALPATH" "$@" && \
263263
ln -sf "$$REALPATH" "$@"
264264
ifneq ($(USE_SYSTEM_LLVM),0)

contrib/mac/frameworkapp/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ signedproductarchive: $(PRODUCTARCHIVE)
116116
mv $<.signed $<
117117

118118
clean:
119-
-rm -rf $(XCARCHIVE) $(XCDERIVEDDATA) $(XCEXPORT)
120-
-rm -rf $(FRAMEWORK_DESTDIR)
119+
rm -rf $(XCARCHIVE) $(XCDERIVEDDATA) $(XCEXPORT)
120+
rm -rf $(FRAMEWORK_DESTDIR)
121121
-rm -f $(PRODUCTARCHIVE)
122122

123123
.PHONY: appexport clean productarchive signedproductarchive

deps/curl.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ $(eval $(call staged-install, \
7575
$$(INSTALL_NAME_CMD)libcurl.$$(SHLIB_EXT) $$(build_shlibdir)/libcurl.$$(SHLIB_EXT)))
7676

7777
clean-curl:
78-
-rm $(BUILDDIR)/curl-$(CURL_VER)/build-configured $(BUILDDIR)/curl-$(CURL_VER)/build-compiled
78+
-rm -f $(BUILDDIR)/curl-$(CURL_VER)/build-configured $(BUILDDIR)/curl-$(CURL_VER)/build-compiled
7979
-$(MAKE) -C $(BUILDDIR)/curl-$(CURL_VER) clean
8080

8181
distclean-curl:
82-
-rm -rf $(SRCCACHE)/curl-$(CURL_VER).tar.bz2 $(SRCCACHE)/curl-$(CURL_VER) $(BUILDDIR)/curl-$(CURL_VER)
82+
rm -rf $(SRCCACHE)/curl-$(CURL_VER).tar.bz2 $(SRCCACHE)/curl-$(CURL_VER) $(BUILDDIR)/curl-$(CURL_VER)
8383

8484
get-curl: $(SRCCACHE)/curl-$(CURL_VER).tar.bz2
8585
extract-curl: $(SRCCACHE)/curl-$(CURL_VER)/source-extracted

deps/dsfmt.mk

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ $(SRCCACHE)/dsfmt-$(DSFMT_VER).tar.gz: | $(SRCCACHE)
1515

1616
$(BUILDDIR)/dsfmt-$(DSFMT_VER)/source-extracted: $(SRCCACHE)/dsfmt-$(DSFMT_VER).tar.gz
1717
$(JLCHECKSUM) $<
18-
-rm -r $(dir $@)
18+
rm -rf $(dir $@)
1919
mkdir -p $(dir $@)
2020
$(TAR) -C $(dir $@) --strip-components 1 -xf $<
2121
echo 1 > $@
@@ -47,11 +47,11 @@ $(eval $(call staged-install, \
4747
$$(INSTALL_NAME_CMD)libdSFMT.$$(SHLIB_EXT) $$(build_shlibdir)/libdSFMT.$$(SHLIB_EXT)))
4848

4949
clean-dsfmt:
50-
-rm $(BUILDDIR)/dsfmt-$(DSFMT_VER)/build-compiled
51-
-rm $(BUILDDIR)/dsfmt-$(DSFMT_VER)/libdSFMT.$(SHLIB_EXT)
50+
-rm -f $(BUILDDIR)/dsfmt-$(DSFMT_VER)/build-compiled
51+
-rm -f $(BUILDDIR)/dsfmt-$(DSFMT_VER)/libdSFMT.$(SHLIB_EXT)
5252

5353
distclean-dsfmt:
54-
-rm -rf $(SRCCACHE)/dsfmt*.tar.gz $(SRCCACHE)/dsfmt-$(DSFMT_VER) $(BUILDDIR)/dsfmt-$(DSFMT_VER)
54+
rm -rf $(SRCCACHE)/dsfmt*.tar.gz $(SRCCACHE)/dsfmt-$(DSFMT_VER) $(BUILDDIR)/dsfmt-$(DSFMT_VER)
5555

5656
get-dsfmt: $(SRCCACHE)/dsfmt-$(DSFMT_VER).tar.gz
5757
extract-dsfmt: $(BUILDDIR)/dsfmt-$(DSFMT_VER)/source-extracted

deps/gmp.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,11 @@ $(eval $(call staged-install, \
7272
$$(INSTALL_NAME_CMD)libgmp.$$(SHLIB_EXT) $$(build_shlibdir)/libgmp.$$(SHLIB_EXT)))
7373

7474
clean-gmp:
75-
-rm $(BUILDDIR)/gmp-$(GMP_VER)/build-configured $(BUILDDIR)/gmp-$(GMP_VER)/build-compiled
75+
-rm -f $(BUILDDIR)/gmp-$(GMP_VER)/build-configured $(BUILDDIR)/gmp-$(GMP_VER)/build-compiled
7676
-$(MAKE) -C $(BUILDDIR)/gmp-$(GMP_VER) clean
7777

7878
distclean-gmp:
79-
-rm -rf $(SRCCACHE)/gmp-$(GMP_VER).tar.bz2 \
79+
rm -rf $(SRCCACHE)/gmp-$(GMP_VER).tar.bz2 \
8080
$(SRCCACHE)/gmp-$(GMP_VER) \
8181
$(BUILDDIR)/gmp-$(GMP_VER)
8282

deps/libgit2.mk

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ $(eval $(call staged-install, \
8080
$$(INSTALL_NAME_CMD)libgit2.$$(SHLIB_EXT) $$(build_shlibdir)/libgit2.$$(SHLIB_EXT)))
8181

8282
clean-libgit2:
83-
-rm $(build_datarootdir)/julia/cert.pem
84-
-rm $(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-configured $(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-compiled
83+
-rm -f $(build_datarootdir)/julia/cert.pem
84+
-rm -f $(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-configured $(BUILDDIR)/$(LIBGIT2_SRC_DIR)/build-compiled
8585
-$(MAKE) -C $(BUILDDIR)/$(LIBGIT2_SRC_DIR) clean
8686

8787
get-libgit2: $(LIBGIT2_SRC_FILE)

deps/libssh2.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ $(eval $(call staged-install, \
6161
$$(INSTALL_NAME_CMD)libssh2.$$(SHLIB_EXT) $$(build_shlibdir)/libssh2.$$(SHLIB_EXT)))
6262

6363
clean-libssh2:
64-
-rm $(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-configured $(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-compiled
64+
-rm -f $(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-configured $(BUILDDIR)/$(LIBSSH2_SRC_DIR)/build-compiled
6565
-$(MAKE) -C $(BUILDDIR)/$(LIBSSH2_SRC_DIR) clean
6666

6767

deps/libsuitesparse.mk

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,13 @@ $(build_prefix)/manifest/libsuitesparse: $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARS
8080
echo $(UNINSTALL_libsuitesparse) > $@
8181

8282
clean-libsuitesparse: uninstall-libsuitesparse
83-
-rm $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-compiled
83+
-rm -f $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/build-compiled
8484
-rm -fr $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/lib
8585
-rm -fr $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)/include
8686
-$(MAKE) -C $(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER) clean
8787

8888
distclean-libsuitesparse:
89-
-rm -rf $(SRCCACHE)/SuiteSparse-$(LIBSUITESPARSE_VER).tar.gz \
89+
rm -rf $(SRCCACHE)/SuiteSparse-$(LIBSUITESPARSE_VER).tar.gz \
9090
$(BUILDDIR)/SuiteSparse-$(LIBSUITESPARSE_VER)
9191

9292
get-libsuitesparse: $(SRCCACHE)/SuiteSparse-$(LIBSUITESPARSE_VER).tar.gz
@@ -107,6 +107,6 @@ endif
107107

108108
define manual_libsuitesparse
109109
uninstall-libsuitesparse:
110-
-rm $(build_prefix)/manifest/libsuitesparse
111-
-rm $(addprefix $(build_shlibdir)/lib,$3)
110+
-rm -f $(build_prefix)/manifest/libsuitesparse
111+
-rm -f $(addprefix $(build_shlibdir)/lib,$3)
112112
endef

deps/libuv.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ $(eval $(call staged-install, \
4343
$$(INSTALL_NAME_CMD)libuv.$$(SHLIB_EXT) $$(build_shlibdir)/libuv.$$(SHLIB_EXT)))
4444

4545
clean-libuv:
46-
-rm -rf $(LIBUV_BUILDDIR)/build-configured $(LIBUV_BUILDDIR)/build-compiled
46+
rm -rf $(LIBUV_BUILDDIR)/build-configured $(LIBUV_BUILDDIR)/build-compiled
4747
-$(MAKE) -C $(LIBUV_BUILDDIR) clean
4848

4949

0 commit comments

Comments
 (0)