Fewer warnings in 'make clean' in clean directory #44450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maleadt
reviewed
Mar 5, 2022
Make.inc
Outdated
| -cmd //C rmdir $$(call mingw_to_dos,$(2)/$(3),cd $(2) &&) | ||
| else | ||
| -rm -r $$(abspath $(2)/$(3)) | ||
| -rm -rf $$(abspath $(2)/$(3)) |
Member
There was a problem hiding this comment.
Maybe then also remove the - prefix to these and other rm invocations (so that the exit code is no longer ignored)?
fingolfin
force-pushed
the
mh/clean-make-clean
branch
from
04b9c1a to
74d207c
Compare
staticfloat
approved these changes
Mar 30, 2022
Member
|
Thanks Max! This stuff is tiresome and not so sexy, but I'm glad someone steps up to do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. if one does
rm -rf usr && make clean && makethen there are tons of errors becausermis asked to delete files that don't exist (anymore). So just pass the-foption tormto suppress those useless errors.