Automatically download LLVM build based on host platform#23
Conversation
Co-authored-by: Claude Opus 4.6 <[email protected]>
Co-authored-by: Claude Opus 4.6 <[email protected]>
|
The only annoying thing is that Also, for the record I had issues on a couple of different aarch64-linux machines where compilation with The problem was that Clang was finding the wrong GCC installation, I fixed that by manually passing |
|
|
||
| #include "llvm/Config/llvm-config.h" | ||
| #include "llvm/ADT/StringMap.h" | ||
| #include "llvm/ADT/Twine.h" |
There was a problem hiding this comment.
Is this because different targets have different headers?
There was a problem hiding this comment.
It's a fix to get LLVM 21 tables generating
There was a problem hiding this comment.
It was always a bug:
cpufeatures/tools/gen_target_tables.cpp
Line 155 in 27da145
Twine without including the necessary header file. Previous versions relied on accidental forward inclusion, but that's not very robust (and finally broke with LLVM 21).
|
Looks reasonable |
If this is good to go, can you please merge? I can't do it myself 🙂 |
|
I can merge it but not give you the bit seemingly |
Tested on Linux with x86-64 and aarch64 architectures, and macOS Apple Silicon, for both LLVM 20.1.8 and 21.1.8 (related to #22).
CC @gbaraldi @topolarity.