[release-1.10] Manually backport #4025 #4027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Pkg is in the sysimage on 1.10. Using the development version is more complicated.. I might suggest backporting this without tests 🙈 |
Contributor
Author
Hahaha after the amount of fixes it took me to get the main PR test right, that's a terrifying proposition. The test should be valid now. |
Contributor
Author
|
Luckily the test fails even with the I think I should remove the test here. Now that I think about it, recompiling the whole library just to test a bug so obscure it's been in the language for 4.5 years might not be worth it. Lmk what you think. |
christiangnrd
changed the base branch from
release-1.10
to
backports-release-1.10
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm investigating. Seems like appending
:toJULIA_DEPOT_PATHhides the bug.