Skip to content

Conversation

@DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Oct 22, 2021

This pull request add a new CI job that does the following steps:

  1. Checks that the working directory is clean.
  2. Instantiates the project at ext/HistoricaStdlibGenerator.
  3. Runs the ext/HistoricaStdlibGenerator/generate_historical_stdlibs.jl script.
  4. Checks that the working directory is still clean. If the working directory is dirty, we do the following:
    • Print the output of git status.
    • Print the output of git diff HEAD.
    • Throw an exception, thus causing the CI job to fail.

@DilumAluthge DilumAluthge added the CI continuous integration label Oct 22, 2021
@DilumAluthge DilumAluthge force-pushed the dpa/check-hsg-ci branch 2 times, most recently from b72378c to e08d990 Compare October 22, 2021 07:50
@DilumAluthge
Copy link
Member Author

Note that the check is (correctly) failing.

@DilumAluthge DilumAluthge marked this pull request as ready for review October 25, 2021 05:57
@DilumAluthge DilumAluthge requested a review from a team as a code owner October 25, 2021 05:57
@DilumAluthge DilumAluthge removed the request for review from a team October 25, 2021 05:58
@DilumAluthge DilumAluthge merged commit f49edc8 into master Oct 26, 2021
@DilumAluthge DilumAluthge deleted the dpa/check-hsg-ci branch October 26, 2021 18:31
@IanButterworth
Copy link
Member

It would've been good to have rebased this before merging.
Looking at the failure on the merge there appears to be a problem with generate_historical_stdlibs.jl that may have been introduced with #2795

@IanButterworth
Copy link
Member

The problem with the 1.8.0 entry is because JuliaLang/julia#42806 hasn't landed yet. It's splitting the stdlib name string into first and second character, instead of the two parts of a (name, version) tuple.

@DilumAluthge
Copy link
Member Author

Alright, I've merged JuliaLang/julia#42806.

Can I re-run the generate_historical_stdlibs.jl script now? Or do I need to wait until the nightlies are updated?

@IanButterworth
Copy link
Member

Ah of course, the action can just be re-run.
Seems to run off nightlies so will need to wait

@DilumAluthge
Copy link
Member Author

Alright, I'll wait for the nightlies to update, and then I'll re-run the generate_historical_stdlibs.jl script and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants