Skip to content

Manifest usage log error should be non-fatal #3960

@fonsp

Description

@fonsp

I got this error today in a production server, which caused the process to crash.

Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]: ERROR: TOML Parser error:
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]: /home/fons/.julia/logs/manifest_usage.toml:17338:25 error: string literal ended unexpectedly
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [["/tmp/jl_UekhXS/Manife
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:                          ^
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]: Stacktrace:
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [1] parse
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ ./toml_parser.jl:445 [inlined]
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [2] parsefile(f::String)
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ TOML ~/julia-1.10.4/share/julia/stdlib/v1.10/TOML/src/TOML.jl:43
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [3] (::Pkg.Types.var"#51#54"{String, String, Dates.DateTime, String})()
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ Pkg.Types ~/julia-1.10.4/share/julia/stdlib/v1.10/Pkg/src/Types.jl:541
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [4] mkpidlock(f::Pkg.Types.var"#51#54"{String, String, Dates.DateTime, String}, at::String, pid::Int32; kwopts::@Kwargs{stale_age::Int6>
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ FileWatching.Pidfile ~/julia-1.10.4/share/julia/stdlib/v1.10/FileWatching/src/pidfile.jl:93
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [5] mkpidlock
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ ~/julia-1.10.4/share/julia/stdlib/v1.10/FileWatching/src/pidfile.jl:90 [inlined]
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [6] mkpidlock
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ ~/julia-1.10.4/share/julia/stdlib/v1.10/FileWatching/src/pidfile.jl:88 [inlined]
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [7] write_env_usage(source_file::String, usage_filepath::String)
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ Pkg.Types ~/julia-1.10.4/share/julia/stdlib/v1.10/Pkg/src/Types.jl:539
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [8] Pkg.Types.EnvCache(env::Nothing)
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ Pkg.Types ~/julia-1.10.4/share/julia/stdlib/v1.10/Pkg/src/Types.jl:377
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:   [9] EnvCache
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ ~/julia-1.10.4/share/julia/stdlib/v1.10/Pkg/src/Types.jl:356 [inlined]
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:  [10] Context
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ ~/julia-1.10.4/share/julia/stdlib/v1.10/Pkg/src/Types.jl:406 [inlined]
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:  [11] instantiate(; kwargs::@Kwargs{})
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ Pkg.API ~/julia-1.10.4/share/julia/stdlib/v1.10/Pkg/src/API.jl:1772
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:  [12] top-level scope
Jul 22 14:59:49 ct-bind-4 pluto-slider-server.sh[941]:     @ none:1

Should this error be fatal? I feel like it suddenly surfaces an implementation detail of Pkg.jl, and it should not be a user error.

Perhaps this can be solved automatically, with a warning?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions