Skip to content

Conversation

@KristofferC
Copy link
Member

@KristofferC KristofferC commented Sep 29, 2021

Fixes #462

There should perhaps be some way of doing this with the default compilers but this is an improvement over the status quo nonetheless.

@KristofferC KristofferC changed the title allow passing on flags with the compiler allow passing on flags with the explicit compiler Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #568 (5db37c5) into master (3c928ab) will decrease coverage by 0.83%.
The diff coverage is 68.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   83.22%   82.39%   -0.84%     
==========================================
  Files           2        2              
  Lines         459      460       +1     
==========================================
- Hits          382      379       -3     
- Misses         77       81       +4     
Impacted Files Coverage Δ
src/PackageCompiler.jl 80.99% <68.96%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c928ab...5db37c5. Read the comment docs.

@KristofferC KristofferC force-pushed the kc/cc_args branch 2 times, most recently from c9672f0 to 646c20b Compare September 30, 2021 11:00
@KristofferC KristofferC merged commit 0d84949 into master Sep 30, 2021
@KristofferC KristofferC deleted the kc/cc_args branch September 30, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

call create_sysimage with custom CXX_FLAGS

1 participant