Bug fix: Run Pkg.resolve() after modifying Project.toml #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `compile_package` and `compile_incremental` for packages that have test-only dependencies.
|
i can't compile DataStructures.jl for the same reason-- it has a test-only dependency on Primes. would be great to see this merged! |
Member
Author
|
Hmm, for some reason this seems to have broken the tests (sorry i didn't follow-up earlier). After this change, the This is the error message: ERROR: LoadError: Unsatisfiable requirements detected for package TestPackage [d4c01e28]:
TestPackage [d4c01e28] log:
├─TestPackage [d4c01e28] has no known versions!
└─restricted to versions * by an explicit requirement — no versions left
Stacktrace:
[1] check_constraints(::Pkg.GraphType.Graph) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/GraphType.jl:935
[2] Pkg.GraphType.Graph(::Dict{Base.UUID,Set{VersionNumber}}, ::Dict{Base.UUID,Dict{Pkg.Types.VersionRange,Dict{String,Base.UUID}}}, ::Dict{Base.UUID,Dict{Pkg.Types.VersionRange,Dict{String,Pkg.Types.VersionSpec}}}, ::Dict{Base.UUID,String}, ::Dict{Base.UUID,Pkg.Types.VersionSpec}, ::Dict{Base.UUID,Pkg.Types.Fixed}, ::Bool) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/GraphType.jl:362
[3] deps_graph(::Pkg.Types.Context, ::Dict{Base.UUID,String}, ::Dict{Base.UUID,Pkg.Types.VersionSpec}, ::Dict{Base.UUID,Pkg.Types.Fixed}) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:307
[4] resolve_versions!(::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}, ::Nothing) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:371
[5] resolve_versions! at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:316 [inlined]
[6] up(::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/Operations.jl:1244
[7] #up#29(::Pkg.Types.UpgradeLevel, ::Pkg.Types.PackageMode, ::Bool, ::Base.Iterators.Pairs{Union{},Union{},Tuple{},NamedTuple{(),Tuple{}}}, ::Function, ::Pkg.Types.Context, ::Array{Pkg.Types.PackageSpec,1}) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:198
[8] #up at ./none:0 [inlined]
[9] #up#24 at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:163 [inlined]
[10] #up at ./none:0 [inlined]
[11] resolve at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v1.0/Pkg/src/API.jl:203 [inlined] (repeats 2 times)
[12] top-level scope at none:0
[13] include at ./boot.jl:317 [inlined]
[14] include_relative(::Module, ::String) at ./loading.jl:1044
[15] include(::Module, ::String) at ./sysimg.jl:29
[16] exec_options(::Base.JLOptions) at ./client.jl:266
[17] _start() at ./client.jl:425
in expression starting at /Users/travis/build/JuliaLang/PackageCompiler.jl/sysimg/run_julia_code.jl:2I guess |
This was referenced Jun 18, 2019
Closed
|
Could this be merged now? |
Member
|
Obsolete by #304 |
Member
Author
|
🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
compile_packageandcompile_incrementalfor packages that have test-only dependencies.For example, I was seeing this error when I tried to compile
CSV:Notice that it never adds
DecFPto the newProject.toml, despite CSV.jl having it in its test REQUIRE:https://github.com/JuliaData/CSV.jl/blob/v0.4.3/test/REQUIRE
This is fixed in this PR, and the final step includes one more output block from
Pkg.resolve():