Parse do syntax without desugaring the closure#98
Merged
Conversation
The reference parser represents `do` syntax with a closure for the second argument. However, the nested closure with `->` head is implied rather than present in the surface syntax, which suggests this is a premature desugaring step. Instead we emit a flatter three-argument form for `do`.
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…ax.jl#98) The reference parser represents `do` syntax with a closure for the second argument. However, the nested closure with `->` head is implied rather than present in the surface syntax, which suggests this is a premature desugaring step. Instead we emit a flatter three-argument form for `do`.
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…ax.jl#98) The reference parser represents `do` syntax with a closure for the second argument. However, the nested closure with `->` head is implied rather than present in the surface syntax, which suggests this is a premature desugaring step. Instead we emit a flatter three-argument form for `do`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference parser represents
dosyntax with a closure for the secondargument. That is,
becomes
(do (call f x) (-> (tuple y) (block body)))in the reference parser.However, the nested closure with
->head is implied here rather than presentin the surface syntax, which suggests this is a premature desugaring step.
Instead this PR changes things to emit the flatter structure
(do (call f x) (tuple y) (block body)).Discussed with @JeffBezanson today on a call.
Part of #88