Fix over/underflow in parsing float literals#78
Merged
Conversation
It seems we can't use Base.parse for floats because this disallows underflow. So replicate the logic of it here in julia-level code. This implementation is still somewhat (~15%) slower than Base.parse for some reason.
We probably shoudln't be modifying the memory in a String on the slow
path here, so use a Vector{UInt8} as the buffer instead. Also deal with
some weird codegen issue which came up as a result on julia 1.6 / 1.7.
Add tests.
c42f
force-pushed
the
cjf/parse-float-erange
branch
from
6a54398 to
a1b9780
Compare
Member
Author
|
Uuugh come on. It seems libc |
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…se-float-erange Fix over/underflow in parsing float literals
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…se-float-erange Fix over/underflow in parsing float literals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems we can't use Base.parse for floats because this disallows
underflow. So replicate the logic of it here in julia-level code and allow
errno=ERANGEin the underflow case.This implementation is still somewhat (~15%) slower than Base.parse for some reason.
Should fix #65
TODO: