Skip to content

fix parsing hex floats containing 'f' #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KristofferC merged 2 commits into from
Aug 24, 2022
Merged

fix parsing hex floats containing 'f' #73

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80681f9
fix parsing hex floats containing 'f'
Aug 24, 2022
84eefca
Update test/parser.jl
Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/value_parsing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function julia_string_to_number(str::AbstractString, kind)
end
return x
elseif kind == K"Float"
if !startswith(str,"0x") && 'f' in str
if !startswith(str,"0x") && 'f' in str && !('p' in str)
# This is kind of awful. Should we have a separate Float32 literal
# type produced by the lexer? The `f` suffix is nonstandard after all.
return Base.parse(Float32, replace(str, 'f'=>'e'))
Expand Down
1 change: 1 addition & 0 deletions test/parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,7 @@ tests = [
"```cmd```" => "(macrocall :(Core.var\"@cmd\") \"cmd\")"
# literals
"42" => "42"
"0x1.428a2f98d728bp+341" => "5.643803094122362e102"
Comment thread
KristofferC marked this conversation as resolved.
Outdated
# closing tokens
")" => "(error)"
],
Expand Down