Fix vect parsing with newline before comma#60
Conversation
|
Looks good. Merge? |
|
I'll merge this tomorrow morning, unless Chis chimes in and says this is the wrong fix :) The test is currently a bit awkward, because SyntaxNode/Expr conversion can't handle unexpected |
c42f
left a comment
There was a problem hiding this comment.
Looks good thanks. Let's add such error cases to the tests as s-expressions along with the happy cases.
Ah yeah I didn't see this comment before I wrote the review. Precisely :) |
|
Tests look a lot nicer now. We're now just emitting an |
|
This good to go, or do you think emitting |
c42f
left a comment
There was a problem hiding this comment.
The FIXME with ErrorVal makes me a bit uncomfortable (does seem wrong). But this is still an improvement so I think we can merge and fix that later.
…vect-newline Fix vect parsing with newline before comma
…vect-newline Fix vect parsing with newline before comma
Fixes #59.