Skip to content

Compat for odd Exprs in long form anonymous functions#6

Merged
c42f merged 2 commits intomainfrom
cjf/compat-long-form-anon-funcs
Feb 16, 2022
Merged

Compat for odd Exprs in long form anonymous functions#6
c42f merged 2 commits intomainfrom
cjf/compat-long-form-anon-funcs

Conversation

@c42f
Copy link
Copy Markdown
Member

@c42f c42f commented Feb 14, 2022

The following construct is parsed oddly by the reference parser with the
tuple omitted from the argument list. Add a compatibility hack for that
during Expr conversion.

    function (xs...)
        body
    end

With this we now have compatible parsing for all of the stdlib, so turn
on this test by default.

@c42f c42f force-pushed the cjf/compat-long-form-anon-funcs branch from 62facc7 to 6ebaddb Compare February 14, 2022 05:49
The following construct is parsed oddly by the reference parser with the
tuple omitted from the argument list. Add a compatibility hack for that
during Expr conversion.

    function (xs...)
        body
    end

With this we now have compatible parsing for all of the stdlib, so turn
on this test by default.
@c42f c42f force-pushed the cjf/compat-long-form-anon-funcs branch from 6ebaddb to 105f325 Compare February 16, 2022 07:22
@c42f
Copy link
Copy Markdown
Member Author

c42f commented Feb 16, 2022

With this we now have compatible parsing for all of the stdlib, so turn on this test by default.

Not quite true for 1.8 yet, so this is disabled conditionally for now.

@c42f c42f merged commit a56904d into main Feb 16, 2022
@c42f c42f deleted the cjf/compat-long-form-anon-funcs branch February 16, 2022 07:35
c42f added a commit to JuliaLang/julia that referenced this pull request Oct 17, 2025
…aSyntax.jl#6)

The following construct is parsed oddly by the reference parser with the
tuple omitted from the argument list. Add a compatibility hack for that
during Expr conversion.

    function (xs...)
        body
    end

With this we now have compatible parsing for all of the stdlib for Julia
1.6 and 1.7, so turn on this test by default in those cases.
topolarity pushed a commit to JuliaLang/julia that referenced this pull request Nov 14, 2025
…aSyntax.jl#6)

The following construct is parsed oddly by the reference parser with the
tuple omitted from the argument list. Add a compatibility hack for that
during Expr conversion.

    function (xs...)
        body
    end

With this we now have compatible parsing for all of the stdlib for Julia
1.6 and 1.7, so turn on this test by default in those cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant