Disallow trailing junk in generators #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disallow generator syntax with trailing non-delimited expressions
(y for x in xs a)
(y for x in xs a, b)
Allow parameter syntax such as
f(y for x in xs; a)
because the flisp parser allowed this it's used in Base in at least one
location.
Disallow the almost-equivalent block syntax for now:
(y for x in xs; a)
because the flisp parser disallowed it and users can always get the same
thing with some extra parentheses.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
- Coverage 96.21% 96.18% -0.04%
==========================================
Files 13 13
Lines 4171 4033 -138
==========================================
- Hits 4013 3879 -134
+ Misses 158 154 -4 ☔ View full report in Codecov by Sentry. |
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
Disallow generator syntax with trailing non-delimited expressions
(y for x in xs a)
(y for x in xs a, b)
Allow parameter syntax such as
f(y for x in xs; a)
because the flisp parser allowed this it's used in Base in at least one
location.
Disallow the almost-equivalent block syntax for now:
(y for x in xs; a)
because the flisp parser disallowed it and users can always get the same
thing with some extra parentheses.
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
Disallow generator syntax with trailing non-delimited expressions
(y for x in xs a)
(y for x in xs a, b)
Allow parameter syntax such as
f(y for x in xs; a)
because the flisp parser allowed this it's used in Base in at least one
location.
Disallow the almost-equivalent block syntax for now:
(y for x in xs; a)
because the flisp parser disallowed it and users can always get the same
thing with some extra parentheses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow generator syntax with trailing non-delimited expressions
Allow parameter syntax such as
because the flisp parser allowed this it's used in Base in at least one location.
Disallow the almost-equivalent block syntax for now:
because the flisp parser disallowed it and users can always get the same thing with some extra parentheses.
Fixes #407