Fix premature lowering of cmd strings #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unadorned backtick command syntax was prematurely lowered to a macrocall in the parser with the `core_@cmd` macro name. Remove this special macro name (almost the last of the special zero-width tokens to be removed!) and rely instead on the presence of unadorned `cmdstring` to do the lowering to a `Core.@cmd` call later during Expr conversion. Also some clean up `Kind`s, grouping them more sensibly and removing the obsolete kinds `K"core_@int128_str"` `K"core_@uint128_str"` `K"core_@big_str"`.
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
Unadorned backtick command syntax was prematurely lowered to a macrocall in the parser with the `core_@cmd` macro name. Remove this special macro name (almost the last of the special zero-width tokens to be removed!) and rely instead on the presence of unadorned `cmdstring` to do the lowering to a `Core.@cmd` call later during Expr conversion. Also some clean up `Kind`s, grouping them more sensibly and removing the obsolete kinds `K"core_@int128_str"` `K"core_@uint128_str"` `K"core_@big_str"`.
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
Unadorned backtick command syntax was prematurely lowered to a macrocall in the parser with the `core_@cmd` macro name. Remove this special macro name (almost the last of the special zero-width tokens to be removed!) and rely instead on the presence of unadorned `cmdstring` to do the lowering to a `Core.@cmd` call later during Expr conversion. Also some clean up `Kind`s, grouping them more sensibly and removing the obsolete kinds `K"core_@int128_str"` `K"core_@uint128_str"` `K"core_@big_str"`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unadorned backtick command syntax was prematurely lowered to a macrocall in the parser with the
core_@cmdmacro name. Remove this special macro name (almost the last of the special zero-width tokens to be removed!) and rely instead on the presence of unadornedcmdstringto do the lowering to aCore.@cmdcall later during Expr conversion.Also some clean up
Kinds, grouping them more sensibly and removing the obsolete kindsK"core_@int128_str"K"core_@uint128_str"K"core_@big_str".Fix #438