Cleanup/document source code access functions + add filename()
#470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move all source code access functions which refer to source locations and strings into the top of source_files.jl, and add some documentation for these. * Add `filename()` function to determine source file name of a syntax object * Also add a minor generalization to SyntaxNode->Expr conversion code to make Expr conversion general enough to allow it to also be used for JuliaLowering.SyntaxTree. (internal/experimental interface, for now)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
==========================================
- Coverage 96.55% 96.09% -0.47%
==========================================
Files 14 13 -1
Lines 4244 3990 -254
==========================================
- Hits 4098 3834 -264
- Misses 146 156 +10 ☔ View full report in Codecov by Sentry. |
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…iaLang/JuliaSyntax.jl#470) * Move all source code access functions which refer to source locations and strings into the top of source_files.jl, and add some documentation for these. * Add `filename()` function to determine source file name of a syntax object * Also add a minor generalization to SyntaxNode->Expr conversion code to make Expr conversion general enough to allow it to also be used for JuliaLowering.SyntaxTree. (internal/experimental interface, for now)
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…iaLang/JuliaSyntax.jl#470) * Move all source code access functions which refer to source locations and strings into the top of source_files.jl, and add some documentation for these. * Add `filename()` function to determine source file name of a syntax object * Also add a minor generalization to SyntaxNode->Expr conversion code to make Expr conversion general enough to allow it to also be used for JuliaLowering.SyntaxTree. (internal/experimental interface, for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filename()function to determine source file name of a syntax object