Backport release 0.4 #468
Merged
Backport release 0.4 #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch `\r\n\r\n` would be tokenized as `\r\n\r` and `\n` instead of `\r\n` and `\r\n`. Fixes fredrikekre/Runic.jl#15. (cherry picked from commit a11e664, PR #460)
Member
Author
|
@c42f do you know which commits need to be backported to make tests pass on 1.10? Looks like 0.4.8 also fail on 1.10 though... Perhaps we can merge and release this anyway? |
When looking at the help for `peek` in the repl, the current docstring looks like it applies to all `IO`, so I added `::ParseStream` to make it more specific. See also JuliaLang/julia#54749
* Don't assume (io::IOBuffer).data is a Vector on new versions of Julia * Exclude test/subtype.jl from corpus due to new dependence on where precedence (#395)
* Run CI on 1.9 and prerelease * Bump setup-julia to v2
This syntax is normally not something you'd use, but it's very useful for `ccall`. Previously the parser just crashed on this kind of input - a bug which is also present in the old parser.
Member
|
We'd need to backport most of @LilithHafner's recent CI fixes. I've done that, plus several other low risk items and pushed to the branch :) |
c42f
approved these changes
Jul 21, 2024
Member
There was a problem hiding this comment.
I think this should be good now!
Everything here should be low risk fixes - do you want to merge this and make the release?
For big and higher risk changes I would also run the ecosystem parsing tests in tools/check_all_packages.jl. But those aren't completely simple to set up (the package cache takes a while to download), and are somewhat nontrivial to interpret 😬
Member
Author
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sure there are more fixes to backport but these are the ones I care about right now. If I, or someone else, needs other fixes we can release 0.4.10 with more backports.