Reduce invalidation/recompliation for parser usage in sysimage#46
Merged
Conversation
c42f
force-pushed
the
c42f/core-hook-fixes
branch
from
f82b6b5 to
f6755f4
Compare
A fixed world age for the parser prevents the need for recompilation of the parser due to any user-defined methods.
c42f
force-pushed
the
c42f/core-hook-fixes
branch
from
f6755f4 to
04a3dfd
Compare
Member
Author
|
This also seems to work in julia-1.9 dev, so let's go with it for now. |
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…re-hook-fixes Reduce invalidation/recompliation for parser usage in sysimage
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…re-hook-fixes Reduce invalidation/recompliation for parser usage in sysimage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refto hide the invocation of the main hook function from the compilerI don't understand why the use of the
Ref(the second commit) seems necessary here; I would have thought thatinvoke_in_worldshould have done the job. But when I tested on Julia 1.7.3 without theRef, loading theTerminalLoggerspackage caused significant latency on the next parse time.Presumably the
Refbreaks some extra backedges, though I'm not sure what they are or how best to debug the situation. (PerhapsSnoopCompile? I'd need to learn how to use that tooling.)