Skip to content

Fix corpus tests on Julia 1.10+ #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LilithHafner merged 2 commits into from
Jul 2, 2024
Merged

Fix corpus tests on Julia 1.10+ #447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
332a32c
Fix corpus tests on Julia 1.10+
LilithHafner Jul 2, 2024
91f205a
Keep returning exprs_roughtly_equal on low versions
LilithHafner Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions test/parse_packages.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,17 @@ base_tests_path = joinpath(Sys.BINDIR, Base.DATAROOTDIR, "julia", "test")
return nothing
end

if endswith(f, "core.jl")
# Loose comparison due to `for f() = 1:3` syntax
return exprs_roughly_equal
if endswith(f, "core.jl")
# The test
# @test Union{Tuple{T}, Tuple{T,Int}} where {T} === widen_diagonal(Union{Tuple{T}, Tuple{T,Int}} where {T})
# depends on a JuliaSyntax bugfix and parses differently (wrong) using
# flisp. This was added in julia#52228 and backported in julia#52045
if v"1.10.0-rc1.39" <= VERSION
return nothing
else
# Loose comparison due to `for f() = 1:3` syntax
return exprs_roughly_equal
end
end

return exprs_equal_no_linenum
Expand Down