add more specific error for invalid identifier start chars #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 94.61% 96.17% +1.56%
==========================================
Files 14 14
Lines 4178 4185 +7
==========================================
+ Hits 3953 4025 +72
+ Misses 225 160 -65 ☔ View full report in Codecov by Sentry. |
c42f
approved these changes
Jul 23, 2024
Member
c42f
left a comment
c42f
left a comment
There was a problem hiding this comment.
Sounds good. I added an extra test and tweaked the error message to include the character in analogy to the existing ErrorUnknownCharacter etc + rebased to get the CI fixes.
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…/JuliaSyntax.jl#421) * add more specific error for invalid identifier start chars * Tweak ErrorIdentifierStart message + add diagnostics test. --------- Co-authored-by: Claire Foster <[email protected]>
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…/JuliaSyntax.jl#421) * add more specific error for invalid identifier start chars * Tweak ErrorIdentifierStart message + add diagnostics test. --------- Co-authored-by: Claire Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some characters can continue but not start an identifier. Currently these give an "unknown unicode character" error, which could be more accurate.