Fix crashes due to lexing ambiguity of string delimiters #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some lexing ambituities in primes vs cmd delimiters. We break
these with a simple rule in the lexer but there's edge cases of invalid
or extremely strange syntax where this can be inconsistent with the
parser. The following were some such cases which caused an assertion
error in the parser.
"var\"#\"``\$"
"x in'``\$"
This change avoids crashing in those cases, emitting an error instead.
See also #25
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 14 14
Lines 4187 4193 +6
=======================================
+ Hits 4044 4050 +6
Misses 143 143 ☔ View full report in Codecov by Sentry. |
c42f
added a commit
that referenced
this pull request
Dec 6, 2023
There are some lexing ambituities in primes vs cmd delimiters. We break
these with a simple rule in the lexer but there's edge cases of invalid
or extremely strange syntax where this can be inconsistent with the
parser. The following were some such cases which caused an assertion
error in the parser.
"var\"#\"``\$"
"x in'``\$"
This change avoids crashing in those cases, emitting an error instead.
See also #25
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…uliaSyntax.jl#394) There are some lexing ambituities in primes vs cmd delimiters. We break these with a simple rule in the lexer but there's edge cases of invalid or extremely strange syntax where this can be inconsistent with the parser. The following were some such cases which caused an assertion error in the parser. "var\"#\"``\$" "x in'``\$" This change avoids crashing in those cases, emitting an error instead. See also JuliaLang/JuliaSyntax.jl#25
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…uliaSyntax.jl#394) There are some lexing ambituities in primes vs cmd delimiters. We break these with a simple rule in the lexer but there's edge cases of invalid or extremely strange syntax where this can be inconsistent with the parser. The following were some such cases which caused an assertion error in the parser. "var\"#\"``\$" "x in'``\$" This change avoids crashing in those cases, emitting an error instead. See also JuliaLang/JuliaSyntax.jl#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some lexing ambituities in primes vs cmd delimiters. We break these with a simple rule in the lexer but there's edge cases of invalid or extremely strange syntax where this can be inconsistent with the parser. The following were some such cases which caused an assertion error in the parser.
This change avoids crashing in those cases, emitting an error instead.
See also #25
Fix part of #380