Skip to content

Fix crash with empty macro name when parsing "@(" #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c42f merged 1 commit into from
Nov 6, 2023
Merged

Fix crash with empty macro name when parsing "@(" #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2316,6 +2316,9 @@ function fix_macro_name_kind!(ps::ParseState, macro_name_position, name_kind=not
elseif k == K"parens"
# @(A) x ==> (macrocall (parens @A) x)
macro_name_position = first_child_position(ps, macro_name_position)
if macro_name_position == NO_POSITION
return
end
k = peek_behind(ps, macro_name_position).kind
elseif k == K"error"
# Error already reported in parse_macro_name
Expand Down
2 changes: 2 additions & 0 deletions test/parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -999,6 +999,8 @@ parsestmt_test_specs = [
# shouldn't crash
"@(x y)" => "(macrocall (parens @x (error-t y)))"
"|(&\nfunction" => "(call | (& (function (error (error)) (block (error)) (error-t))) (error-t))"
"@(" => "(macrocall (parens (error-t)))"
"x = @(" => "(= x (macrocall (parens (error-t))))"

# The following is currently broken but at least the parser shouldn't
# crash.
Expand Down