Always emit() nodes with zero children, don't bump() them
#371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup weird cases where the parser would `bump()` interior nodes into the output stream rather than `emit()`ing them. Emitting all interior nodes explicitly means we can remove some special cases which occurred during tree building. As part of this, fix some errors converting broken expressions like `x var"y"` from `SyntaxNode` to `Expr`.
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
==========================================
+ Coverage 96.56% 96.58% +0.02%
==========================================
Files 14 14
Lines 4161 4160 -1
==========================================
Hits 4018 4018
+ Misses 143 142 -1
|
This was referenced Oct 22, 2023
c42f
added a commit
that referenced
this pull request
Nov 12, 2023
Cleanup weird cases where the parser would `bump()` interior nodes into the output stream rather than `emit()`ing them. Emitting all interior nodes explicitly means we can remove some special cases which occurred during tree building. As part of this, fix some errors converting broken expressions like `x var"y"` from `SyntaxNode` to `Expr`.
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…ang/JuliaSyntax.jl#371) Cleanup weird cases where the parser would `bump()` interior nodes into the output stream rather than `emit()`ing them. Emitting all interior nodes explicitly means we can remove some special cases which occurred during tree building. As part of this, fix some errors converting broken expressions like `x var"y"` from `SyntaxNode` to `Expr`.
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…ang/JuliaSyntax.jl#371) Cleanup weird cases where the parser would `bump()` interior nodes into the output stream rather than `emit()`ing them. Emitting all interior nodes explicitly means we can remove some special cases which occurred during tree building. As part of this, fix some errors converting broken expressions like `x var"y"` from `SyntaxNode` to `Expr`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup weird cases where the parser would
bump()interior nodes into the output stream rather thanemit()ing them. Emitting all interior nodes explicitly means we can remove some special cases which occurred during tree building.As part of this, fix some errors converting broken expressions like
x var"y"fromSyntaxNodetoExpr.Fixes #330