Merged
Conversation
pfitzseb
force-pushed
the
sp/fix-dotop-tokenization
branch
from
f850514 to
f3ecbbe
Compare
pfitzseb
force-pushed
the
sp/fix-dotop-tokenization
branch
from
f3ecbbe to
52f7546
Compare
c42f
approved these changes
Jun 24, 2022
Member
c42f
left a comment
c42f
left a comment
There was a problem hiding this comment.
Excellent, thanks very much :-)
I streamlined the tests a bit. Let's merge, provided CI likes it.
I also thought about adding the token kind to the tests, as is done in some other places. But that made the tests much more verbose and hard to understand, so I left it out out in the end.
| end | ||
|
|
||
| @testset "dotop miscellanea" begin | ||
| broken_ops = [ |
Member
There was a problem hiding this comment.
Well, not all of these are broken :-)
c42f
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…dotop-tokenization Fix some dotop tokenization issues
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…dotop-tokenization Fix some dotop tokenization issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31.