Fixes for SourceFile byte offsets
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash formatting error messages when core_parse_hook is used to parse a piece of broken code with a nontrivial byte offset. * `SourceFile` held by `SyntaxNode` preserves the indexing of the original string passed to the `parse*()` functions. * Fix `source_line_range` and `thisind` accordingly
Codecov Report
@@ Coverage Diff @@
## main #311 +/- ##
==========================================
+ Coverage 96.78% 96.80% +0.01%
==========================================
Files 14 14
Lines 4111 4125 +14
==========================================
+ Hits 3979 3993 +14
Misses 132 132
|
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…ix-SourceFile-offsets Fixes for `SourceFile` byte offsets
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…ix-SourceFile-offsets Fixes for `SourceFile` byte offsets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash formatting error messages when core_parse_hook is used to parse a piece of broken code with a nontrivial byte offset.
SourceFileheld bySyntaxNodepreserves the indexing of the original string passed to theparse*()functions.source_line_rangeandthisindaccordingly