Add trailing line numbers to loops in Expr conversion #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These trailing line numbers are used to attribute coverage to the `end` of the loop for parts of the loop header which run there after lowering.
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 14 14
Lines 4090 4094 +4
=======================================
+ Hits 3958 3962 +4
Misses 132 132
|
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…aSyntax.jl#298) These trailing line numbers are used to attribute coverage to the `end` of the loop for parts of the loop header which run there after lowering.
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…aSyntax.jl#298) These trailing line numbers are used to attribute coverage to the `end` of the loop for parts of the loop header which run there after lowering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These trailing line numbers are used to attribute coverage to the
endof the loop for parts of the loop header which run there after lowering.At least, I think that's what's going on with the fact that coverage changes when using JuliaSyntax in Base.