Conversation
Instead of baking this into the parser output, we treat this extra block as an Expr-specific oddity and add it during Expr conversion.
This should give proper line number information when using JuliaSyntax via the Julia runtime. And hopefully allow tools like Revise.jl to work reliably.
c42f
force-pushed
the
cjf/core-parsing-fixes
branch
from
64aa946 to
0976ded
Compare
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…e-parsing-fixes Emit `LineNumberNode`s in `Expr` conversion
topolarity
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 14, 2025
…e-parsing-fixes Emit `LineNumberNode`s in `Expr` conversion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper line number generation in blocks, top level, etc, and pass file names through the core parser hook function. This isn't 100% compatible with the flisp parser's line numbers as the flisp parser has a few weird quirks in some corner cases. Hopefully it's close enough, though.
Seems to be enough to get Revise to work for JuliaSyntax-based sysimages 🤞 At least in simple cases.