Skip to content

Treat UTF-8 BOM as whitespace #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c42f merged 1 commit into from
May 18, 2022
Merged

Treat UTF-8 BOM as whitespace #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tokenize/src/lexer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export tokenize
@inline ishex(c::Char) = isdigit(c) || ('a' <= c <= 'f') || ('A' <= c <= 'F')
@inline isbinary(c::Char) = c == '0' || c == '1'
@inline isoctal(c::Char) = '0' ≤ c ≤ '7'
@inline iswhitespace(c::Char) = Base.isspace(c)
@inline iswhitespace(c::Char) = Base.isspace(c) || c === '\ufeff'

struct StringState
triplestr::Bool
Expand Down
13 changes: 13 additions & 0 deletions Tokenize/test/lexer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,3 +868,16 @@ end
check_kw_hashes(String([cs...]) for cs in Iterators.product(['a':'z' for _ in 1:len]...))
end
end


@testset "UTF-8 BOM" begin
@test Tokenize.Tokens.kind.(collect(tokenize("\ufeff[1\ufeff2]"))) == [
Tokens.WHITESPACE,
Tokens.LSQUARE,
Tokens.INTEGER,
Tokens.WHITESPACE,
Tokens.INTEGER,
Tokens.RSQUARE,
Tokens.ENDMARKER
]
end